Skip to content

Conversation

youngsofun
Copy link
Member

@youngsofun youngsofun commented Sep 25, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

  1. better naming
    • HttpQueryState -> ClientState, distingush with execute_state
    • use word closed client to distinguish from stopped execution, and removed from manager
  2. clearer state machine
    • remove tombstone by timeout instead of using a fix-sized FIFO queue. and finalized query is removed earlier.
    • Removed confusing is_data_drained atomic bool
  3. Data Drainage Tracking
    • Prevents unnecessary timestamp updates after drainage
    • Notifies heartbeat handler when heartbeats are no longer needed

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Sep 25, 2025
@youngsofun youngsofun force-pushed the query_finish branch 2 times, most recently from c0912cf to 104c8aa Compare September 25, 2025 22:05
@youngsofun youngsofun force-pushed the query_finish branch 2 times, most recently from 868eb44 to f359921 Compare September 26, 2025 03:29
@youngsofun youngsofun marked this pull request as draft September 26, 2025 05:26
@youngsofun youngsofun changed the title refactor: polish handling of HttpQuery waiting for final. refactor: clarify the HTTP query lifecycle. Oct 10, 2025
@youngsofun youngsofun force-pushed the query_finish branch 9 times, most recently from 6e692a1 to 4658e5f Compare October 10, 2025 23:55
@youngsofun youngsofun marked this pull request as ready for review October 10, 2025 23:58
Ok(())
}

#[fastrace::trace(name = "ExecuteState::execute")]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trace name should update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-refactor this PR changes the code base without new features or bugfix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants